davidortinau / Xappy

A mobile app to track Xamarin news and explore all the goodness that is .NET for Mobile developers
MIT License
350 stars 106 forks source link

Local man takes liberties when fixing minor bug #19

Closed rdavisau closed 5 years ago

rdavisau commented 5 years ago

Hello, I've been watch the VODs back each day when I'm working. Tonight I took a squiz at Lil Proppy and I noticed that it wasn't possible to display a single property's editor twice in a row - without first presenting another property's editor - because SelectionChanged will not fire (another case where an ItemTapped-style api would help).

I added a fix for this, but in the process got a little carried away and refactored a few items. If you're not keen on the other changes you can just take ClearSelection from the diff and call it after dismissing the editor control (also check for empty selection in Handle_SelectionChanged). I won't be offended

The other changes were:

I tested this on iOS and don't believe I broke anything. There's still plenty of time for QA, right? đŸ¤ 

davidortinau commented 5 years ago

Love it, thanks @rdavisau !