Hello, I've been watch the VODs back each day when I'm working. Tonight I took a squiz at Lil Proppy and I noticed that it wasn't possible to display a single property's editor twice in a row - without first presenting another property's editor - because SelectionChanged will not fire (another case where an ItemTapped-style api would help).
I added a fix for this, but in the process got a little carried away and refactored a few items. If you're not keen on the other changes you can just take ClearSelection from the diff and call it after dismissing the editor control (also check for empty selection in Handle_SelectionChanged). I won't be offended
The other changes were:
factored out the property editor selection to a seperate method. I think there are opportunities to modify the method itself, but for a sample you also probably don't want to get too clever
factored out 'present editor' and 'dismiss presented editor' methods
added easing to the entry/exit animations, (you mentioned it on stream and I thought the same), and a fade on the property list
waited on the exit animation before removing the editor from the grid (fixes it disappearing instantly)
disabled interaction on the toolbar and property list during entry/exit animation, to help prevent Bad Things Happening like the user quickly selecting two properties and causing multiple controls to animate in. There are other options for handling this, but for a sample this is relatively clean/simple, if a little heavy handed.
I tested this on iOS and don't believe I broke anything. There's still plenty of time for QA, right? đŸ¤
Hello, I've been watch the VODs back each day when I'm working. Tonight I took a squiz at Lil Proppy and I noticed that it wasn't possible to display a single property's editor twice in a row - without first presenting another property's editor - because
SelectionChanged
will not fire (another case where anItemTapped
-style api would help).I added a fix for this, but in the process got a little carried away and refactored a few items. If you're not keen on the other changes you can just take
ClearSelection
from the diff and call it after dismissing the editor control (also check for empty selection inHandle_SelectionChanged
). I won't be offendedThe other changes were:
I tested this on iOS and don't believe I broke anything. There's still plenty of time for QA, right? đŸ¤