About page - Githubissues

davidortinau / Xappy

A mobile app to track Xamarin news and explore all the goodness that is .NET for Mobile developers

MIT License

350 stars 106 forks source link

About page #24

Closed Depechie closed 5 years ago

Depechie commented 5 years ago

Initial draft PR to show off potential About page design

[x] Show info about the app itself in general area
[x] Show list of contributors
[x] Navigate to contributor profile on GitHub when selected
[ ] Loading animation?
[ ] Pull to refresh?

Fixes #16

Current preview:

davidortinau commented 5 years ago

@pureween, look at the image above ^. I know you addressed the SafeArea / padding type situation for the header. Does the fix also account for the top tab bar? This is pre9.

PureWeen commented 5 years ago

Yes it should

PureWeen commented 5 years ago

Here's this if you want to try it out and see if it resolves it

Xamarin.Forms.4.0.0.388654-pre10.zip

Depechie commented 5 years ago

So @davidortinau will you add this pre10 to the Master branch? That way I can take it over on my Fork > Branch

davidortinau commented 5 years ago

@Depechie pre10 is now in master.

Depechie commented 5 years ago

@PureWeen if pre10 is applied, do I still need to provide some code to get this going? Default rendering does not fix this. Also tried applying UseSafeArea="true" with no luck.

Depechie commented 5 years ago

@davidortinau this can be merged now...