search

davidpdrsn / CardistryIO

The cardistry community of the future
cardistry.io
8 stars 4 forks source link

Add pagination to feed #212

Closed davidpdrsn closed 8 years ago

davidpdrsn commented 8 years ago

Fixes https://github.com/davidpdrsn/CardistryIO/issues/208

Whats new

Currently the feed displays all activities since the beginning of time. That is not very sustainable since the number of views to render will just grow and grow forever.

This replaces the "Today", "Yesterday", etc, groupings and instead uses basic pagination. I found the logic for the grouping hard to understand and took that as a sign it might also be hard for users to understand. For example if a move is 3 days old, should it appear under "Last week"? To me last week would mean stuff that happened last week, but 3 days ago might still be the current week.

I'm personally not a big fan of infinite scrolling feeds since they break the back button which I find very frustrating. This find of pagination is also easier to implement since I could reuse PaginatedRelation.

Any thoughts?

Whats missing

A few design things for @bendobos

bendobos commented 8 years ago

This is now ready to be merged.