davidpdrsn / juniper-eager-loading

Library for avoiding N+1 query bugs with Juniper
68 stars 8 forks source link

`load_children` only gets called if `child_ids` returns `LoadResult::Ids` #27

Closed davidpdrsn closed 5 years ago

davidpdrsn commented 5 years ago

I was thinking that load_children didn't really make sense for and HasManyThrough. Turns out it doesn't get called at all. That is kinda weird and should probably be cleaned up. Having to add unreachable!() inside that method is odd.