dist folder - Githubissues

gxribeiro commented 7 years ago

Could be placed on Release page the download of dist folder , like others: https://github.com/chartjs/Chart.js/releases/tag/v2.6.0 https://github.com/facebook/react/releases/tag/v15.6.1

In my case, only the dist folder solves all my problems and i think solves problems of many others. Anyway, i have several problems with my generated dist folder. Let me describe my steps:

npm install
npm build
gulp

and when i try to start my simple demo page, a error occurs: Uncaught Error: Cannot find module 'react'

My "demo project" is the same as old orb project and basiclly this:

<head>
    <script type="text/javascript" src="https://unpkg.com/react@15.5.4/dist/react.js"></script>
    <script type="text/javascript" src="https://unpkg.com/react-dom@15.5.4/dist/react-dom.js"></script>
    <link rel="stylesheet" type="text/css" href="../dist/orb.css" />
    <script type="text/javascript" src="../dist/orb.js"></script>
</head>

Note: Was tryed with/without react.js and react-dom.js

Solution (poor solution) is change all require('react') by this:

//var React = require('react');
//var ReactDOM = require('react-dom');

var React = typeof window === 'undefined' ? require('react') : window.React;
var ReactDOM = typeof window === 'undefined' ? require('react-dom') : window.ReactDOM;

Sorry for my poor English and my poor solution and thanks for the old Orb continuitty.

Chamousse commented 7 years ago

David,

Have you a complete Sample with the new ORB ? A sample with htlml file ?

Thanks for all

gxribeiro commented 7 years ago

Chamousse

You can use the old Orb Sample. Latest Orb will works with the old Orb sample as well. https://github.com/nnajm/orb/tree/master/demo

Chamousse commented 2 years ago

Hello David

Have you another version of ORB.js please ? Have you a sample asp.net mvc to share me with this library ? I'm not able to use it.

Thanks a lot

Moussa

De : gxribeiro @.> Envoyé : lundi 24 juillet 2017 15:07 À : davidpelayo/orb-latest @.> Cc : Chamousse @.>; Comment @.> Objet : Re: [davidpelayo/orb-latest] dist folder (#5)

Chamousse

You can use the old Orb Sample. Latest Orb will works with the old Orb sample. https://github.com/nnajm/orb/tree/master/demo

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/davidpelayo/orb-latest/issues/5#issuecomment-317416730, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVbZRZmzg4d2RuJN3T4qEB9iOZGURmtAks5sRJcRgaJpZM4Oc-3B.

davidpelayo / orb-latest

dist folder #5