Missing $forcedownload argument in tincanlaunch_pluginfile

davidpesce / moodle-mod_tincanlaunch

A Moodle plugin that allows the launching of xAPI content using the Rustici Launch Method.

45 stars 41 forks source link

Missing $forcedownload argument in tincanlaunch_pluginfile #218

Closed ahelton-ips closed 1 year ago

ahelton-ips commented 3 years ago

I am using the master branch as of 8/3/21 of moodle-mod_tincanlaunch. I am running Moodle 3.8.9.

Ran into an issue when launch a SCORM package via tincanlaunch_pluginfile. The core filelib.php provides an additional $forcedownload parameter to tincanlaunch_pluginfile function.

It will currently display the following error:

I was able to add the $forcedownload paramater to tincanlaunch_pluginfile, and it resolved the issue.

davidpesce commented 1 year ago

Hi @ahelton-ips - sorry for the long reply on this. Thank you for your contribution! It has been approved and merged into master.