search

davidpmccormick / btmat-nuxt

1 stars 1 forks source link

SiteNav problem (navigating to wrong links) #4

Closed alexgil1994 closed 4 years ago

alexgil1994 commented 5 years ago

Hello, i happened to come across with this repo searching for Nuxt projects and I found out after watching the live page made by the project (since the I found interesting the purpose that the app has which is about a charity) that the navigations are wrong. Of course through Google searching it does navigate to existing links but using the inner navigation through the header the links don't work.

For example through Google you are navigated to /news/ but through the inner navigation you are navigated to /news , the last / is missing which means it wont go to the desired index page.

After a couple of minutes inspecting I found out that the problem starts from how those links are being specified in the Vuex state, since I saw that the SiteNav uses those itemNav objects taken from the state.

So the fix is easy I believe, just fix the links in the index.js in the Vuex store. I could do a pull request to help you out but I thought of instead informing you through this Issue so that I wouldn't break anything else by mistake.

Great project for a great purpose! Cheers :)

davidpmccormick commented 4 years ago

Hey – sorry, I totally missed this when it came in.

Thanks for taking an interest in the project and for filing the issue. I've not been able to replicate it (doesn't appear to make a difference with/without the trailing /).

Going to close this, but obviously feel free to re-open if you think I've missed something.