Where to put gating and comp dictionaries

[davidpng]

Lets ask around and see what is the better place to put 'global' variables like gating and comp dictionaries. I'd hate to have to do it in the command line.

[hermands]

We already discussed this. We agreed we could either put the dictionaries as python in a class (or init) or as files that are loaded in by classes. This way this information can be maintained independently from any code, is expandable, and can have multiple versions. I would propose a class that that gets cytnum and spits out the comp matrix. At some point if we wanted to do something fancier this class could also take date.

If others have better thoughts, let's use them.

But, just like you want it off the command-line, I want it off the command-line and out of the subcommand.

[hermands]

• If number is small, we could put it in a configuration file in JSON format

[hermands]

I think we should put gates in config file in JSON format. For compensation, we need to explore QC data first.

[hermands]

Need to clarify current naming convention, because coords are clashing in mind and code:

• gating_coords
• feat_coords

[davidpng]

we can call feat_coords as bin_number

On Sun, Jan 4, 2015 at 10:18 PM, Daniel Herman notifications@github.com wrote:

Need to clarify current naming convention, because coords are clashing in mind and code:

• gating_coords
• feat_coords

— Reply to this email directly or view it on GitHub https://github.com/davidpng/FCS_Database/issues/14#issuecomment-68672179 .

[hermands]

That could work. I think first fix is changing the global import to something more specific, like gating_coords

[davidpng]

sure, lets go with that. Do you want me to make the changes?

On Mon, Jan 5, 2015 at 9:13 AM, Daniel Herman notifications@github.com wrote:

That could work. I think first fix is changing the global import to something more specific, like gating_coords

— Reply to this email directly or view it on GitHub https://github.com/davidpng/FCS_Database/issues/14#issuecomment-68740297 .

[hermands]

I'm not going to get back to this branch until later this afternoon

[davidpng]

I have updated test_FCS and test_HDF5 to us gate_coords instead of coords

On Mon, Jan 5, 2015 at 9:25 AM, Daniel Herman notifications@github.com wrote:

I'm not going to get back to this branch until later this afternoon

— Reply to this email directly or view it on GitHub https://github.com/davidpng/FCS_Database/issues/14#issuecomment-68742363 .