davidrapan / ha-solarman

Solarman Stick Logger V5 integration for Home Assistant
MIT License
7 stars 2 forks source link

Overriding Stephen integration #2

Open frsantos opened 4 days ago

frsantos commented 4 days ago

Hi David,

Just saw your new integration and I'd like to test it, but then I just read this comment

And about the override, it works like this: Inverter with same serial number will always override the existing one. This way it works also in the version from Stephen and i kept it that way. Sorry about the inconvenience!

Would be any way of testing this in parallel? I don't like the idea of this overwriting names or values from the other working integration.

Thank you!

PV-Joe commented 4 days ago

Yeah, it took me quiete a while to change the sensor names to the integration by David so my dashboards work again.

davidrapan commented 4 days ago

Before you start it up with my code, you can go through the deye_sg04lp3.yaml and "rematch" the sensor names to suit your needs.

But running both versions side by side (i.e. to compare them) is not possible at the moment. But switching between them should be possible as described above.

As I am now thinking about it, you know what I could add more versions of the definition file for this particular device (which would also involve the original one) ;) I look into it when I have some time to spare. ;)

davidrapan commented 4 days ago

I have a question on how to approach this... Do you want also definition file which will contain only original list of sensors? Or file (which will be the 'default' one) that will contain sensors with original naming + all the new sensors?

davidrapan commented 3 days ago

@frsantos Should be good to go since: c6dfe87

PV-Joe commented 3 days ago

Hi David,

after 3 days of testing an rematching the sensor names I realized that all my historical data from the energy dashboard was gone.

Obviously I don’t want to loose all the history, so I restored my backup to the date before I installed your version.

All my historical data from the energy dashboard is there again with a loss of 3 days but I can live with that, rather than loosing all of it. Rematching the sensors to the original names by Stephen was to confusing for me.

I thought to try your latest version and hoped that this would solve the problem overwriting the old sensor names. It did not, so I restored once again back to the original from: https://github.com/StephanJoubert/home_assistant_solarman

As I much prefer your version as it has more sensors and is much faster pulling the data I would kindly ask you to use the original sensor names by Stephen.

This would make it much easier for me and others to upgrade to your version without doing all the conversion of sensor names.

I also realized that the Solarman configuration page is faulty:

IMG_5554

I wasn’t able to select my “custom_components.yaml” in the Options.

I hope you can make it more convenient for non professionals to use your integration overwriting the original by Stephen.

I will come back to your integration and give it another try when it is more hassle free.

Keep up the good work and hope to be able to use your Solarman in future. I might even go for a name conversion myself if I have more time but I’m scared that the deye_SG04LP3.yaml will be overwritten again by future updates.

Joe

PV-Joe commented 3 days ago

If it will help you to fix compatibility for the Solarman Deye Hybrid integration , here is the YAML I use with the integration 1.4.1 by Stephen Joubert:

`# SUN-8/12K-SG04LP3-EU | 8/12KW | Three Phase | 2 MPPT | Hybrid Inverter | Low Voltage Battery

tested with LSW3_15_FFFF_1.0.91R + LSW3_15_FFFF_1.0.84

requests:

parameters:

davidrapan commented 2 days ago

Are you sure you used the latest version? Cause you can look in the file and see that the sensor names are the same though. :) (ofc if I didn't forget any)

Edit: To be clear I'm talking about 'deye_sg04lp3.yaml' file from Stephans latest version.

Edit2: Ok so it seems that you are also not using Stephan's official inverter definition file. In that case, if you put your yaml file in the 'inverter_definition' folder, you will be able to load it. But only with sensors you defined there, of course.

PV-Joe commented 2 days ago

Hi David,

That sounds great! You are tempting me to give it another try. I’m ready to check it out as soon as possible and will let you know if it works well. I’m backup before, so if anything goes wrong it will be possible to roll back.

Thanks for letting me know!