Correct scopes for comments

[mrmlnc]

Hello, @davidrios,

I think we must understand that a comment is a comment, and not a string. Just buffered and unbuffered comments. For example, JavaScript when block and single-line comments have one scope.

"comment-block": {
    "name": "comment.block.js"
},
"comment-block-doc": {
    "name": "comment.block.documentation.js"
},
"comment-line": {
    "name": "comment.line.js"
}

Also invalid.illegal.comment.comment.block.jade have double comment in scope name.

Before fix (Sublime Text 3 with you package):

After fix (Sublime Text 3 with you package):

[davidrios]

This is intentional, so you can have a visual indication of what will be a part of the final rendered HTML. Do you have another comment scope that will accomplish that on most color themes?

[mrmlnc]

@davidrios, I think we shouldn't talk here about highlighting, because it's a base scope. For example, buffered and unbuffered comments in Less (LESS.tmLanguage#L145-L178) or Sass (SASS.tmLanguage#L73-L88).

[davidrios]

So, what are the dire consequences of having an incorrectly named scope?

[mrmlnc]

@davidrios, formally - no consequences. In practice, people expect to see color of the comment (if the theme is not adapted for Jade/Pug syntax).

In any case, I just suggested the changes. You can reject it 🐼

[mrmlnc]

Closed as outdated.