search

davidrios / pug-tmbundle

A comprehensive textmate / sublime text bundle for the Pug (formerly Jade) template language.
https://github.com/davidrios/pug-tmbundle
MIT License
48 stars 20 forks source link

"tag_classes" must be treated as css classes #21

Closed ginlime closed 1 year ago

ginlime commented 6 years ago

Syntax for classes was not treated as css classes but as attributes. It is not good because difference occured between css meta languages.

mk-startialab commented 3 years ago

@davidrios Hey, please give me any reaction!

ginlime commented 3 years ago

Oops, the comment shown above is my company-related account...

davidrios commented 1 year ago

Do you have a test case or examples for this? Or do you even care still? 😂

ginlime commented 1 year ago

Yes, yes! I care about this matter! I waited the reply from you for a long time! When I reported Pug's syntax highlighting to the VS Code development team, they told me to tell the author of the data...

image

This is the view in VS Code. The upper pane of this image is described by Pug and the lower pane by SCSS.

The CSS class coloring is different between SCSS and Pug, with "entity.other.attribute-name.class.pug" used in "pug.tmLanguage.json". So, I replaced this with "entity.other.attribute-name.class.css" and got the same display results in SCSS and Pug as desired.

I have been working on this replacement every time I upgrade VS Code since the VS Code team says they can't handle the "pug.tmLanguage.json" issue. Not a big task, but still a bit annoying every time...

I'm begging you to align your description with the syntax highlighting of other languages.

Thanks.

davidrios commented 1 year ago

Makes sense. Done.