search

davidrjonas / composer-lock-diff

See what has changed after a composer update
MIT License
274 stars 18 forks source link

Displayed source url #20

Closed enomotodev closed 4 years ago

enomotodev commented 5 years ago

I also wanted to check the source URL even in the case of NEW or REMOVE so I displayed it.

@davidrjonas Please review the PR

davidrjonas commented 5 years ago

This looks clean.

What do you think of linking the package name with the source url in markdown mode instead of adding a column?

enomotodev commented 5 years ago

@davidrjonas Certainly that's better!

I have corrected it so please review.

davidrjonas commented 5 years ago

Also, don't forget to add your name to the contributors list in the readme :wink:

davidrjonas commented 5 years ago

I took a stab at doing it without changing the offset and it worked out pretty easily. Take a look. https://github.com/davidrjonas/composer-lock-diff/commit/9609d9ba6847ced1d1cdfb14c9332382f66c80d1 I didn't update the readme or anything though. Feel free to pull in those changes however you like. I think your name should be on the commit.

davidrjonas commented 5 years ago

Oh, also, I added some test data to make it easier to see all the ways the data is formatted. Rebase on master then run make | $PAGER

enomotodev commented 5 years ago

@davidrjonas Thank you for adding the test. I could easily check the operation.

I tried 9609d9b, but I did not merge because the width was not aligned at mark down.

I have updated the code overall, so please review it.