davidrjonas / composer-lock-diff

See what has changed after a composer update
MIT License
276 stars 18 forks source link

FEATURE : multi SCM support (adding SVN) #29

Closed soleuu closed 3 years ago

soleuu commented 3 years ago

Hello,

Using some SVN project, I have added support for multiple SCM (Source Control Management) and added subversion support.

I have tried to keep coding style and indentation.

Have a good day.

davidrjonas commented 3 years ago

Thanks so much for adding this!

I've got some changes I'd like you to make before I merge. One bigger one is that I'd like to use the term vcs instead of scm to match the composer documentation. Also, please update the readme with the added option as well as your github link at the bottom of the page. Other changes I'll add as comments on the diff.

If you don't want to spend the time on further changes just let me know. You did the hard work already, I don't mind polishing things up.

Thanks again!

soleuu commented 3 years ago

New commit pushed with what your requested. No problem with acronym change as VCS is more commonly used and is more consistent with ecosystem.

As a side note, --from and --to accept standard SVN ref syntax. (and is also working with deleted branches/files if using revision where file exits of course)

#diff with other branch (svn standard syntax)
composer-lock-diff --from ^/branches/myBranch/composer.lock@MyRevision

#diff with other branch (svn standard syntax)
composer-lock-diff --from ^/branches/myBranch/composer.lock

#diff with revision (in current branch).
composer-lock-diff --from MyRevision

Feel free to add it anywhere you think it should.

Have a good day.

soleuu commented 3 years ago

New commit added

soleuu commented 3 years ago

Hello,

I think all the work is done.

Do you have any other suggestions/changes ?

davidrjonas commented 3 years ago

Thanks so much, and thanks for the reminder.

I'm sorry I can't merge your PR yet. I have changes I want to make but haven't had time to get to them. I need to ensure that it will continue to work the way users expect it to and without a decent test suite it is very time consuming to work through all the cases in the code. I got some of it done tonight and I hope to get more done soon. Thanks for your patience.

I also wanted to test it with an actual svn server but I didn't find an easy way to do that. If you know a quick way to test it that'd be helpful.

soleuu commented 3 years ago

hello,

I have created a vagrant VM with scripts to create svn repositories.

git clone https://github.com/soleuu/vagrant_svnserve
cd vagrant_svnserve
vagrant up 
#####

#somewhere else
svn co svn://127.0.0.1/project1
#login and password are hardcoded in script 
#login username1
#password : pasword1

scripts are a mix of :

soleuu commented 3 years ago

Even more simple for SVN server, it is possible to use sourceforge svn hosting feature.

davidrjonas commented 3 years ago

Excellent. I will check it out tonight, probably. I’ve been traveling lately and got some good work done on the plane. I’ll push it up as soon as I get a chance. It generalizes the vcs support so it is pluggable and easy to add others. I’m excited for you to try it, make sure it fits your use case still.

On Jun 12, 2021, at 4:48 AM, soleuu @.***> wrote:

 Even more simple for SVN server, it is possible to use sourceforge svn hosting feature.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.