search

davidrmiller / biosim4

Biological evolution simulator
Other
3.1k stars 435 forks source link

Code cleanup #26

Closed GregEakin closed 2 years ago

GregEakin commented 2 years ago

These are the code changes from review #7. The remaining changes in that review are const variables, and type specifications on constantans.

davidrmiller commented 2 years ago

Some very nice improvements in this collection. I look forward to examining them in detail, but at first cursory glance, they look great.

venzen commented 2 years ago

General question that I think is on-topic here:

What coding standard are you guys using? I work in VS Code and most of the IntelliSense C-standards create a lot of "Problems" noise with code that is perfectly fine. The Gnu standards are more reasonable and only highlight blatant syntax errors and declaration issues. Any suggestions?

davidrmiller commented 2 years ago

@venzen , thanks for asking that. There are many good, common-sense guidelines in the GNU Coding Standards and GCC Coding Conventions, but the nature of this project doesn't require overscrupulousness.

When reviewing PRs, my concerns will be algorithm correctness, *nix portability, and no warnings with gcc -pedantic -Wextra -Wall -std=c++17.

As far as I'm concerned, you can be informal about syntax formatting when submitting PRs. When it's time to publicly review a feature branch, I can tweak the spaces and braces to be consistent with the predominately K&R style of the existing code.

davidrmiller commented 2 years ago

This PR was incorporated in #37. Thanks to @GregEakin for these nice improvements to the code.