fix bug in github action

[mathematicalmichael]

now that it's actually working, i can test it and fix it =)

this checks that any changes made to the code base do not ruin the compilation of the program by ensuring that make still completes.

the problem was that github action runs in an environment where the -ti flag makes no sense, it was sloppy on my part to forget omitting them (just a copy/paste thing). It's the difference between what you want to run on your machine to make it useful to work with VS what you want in CI to perform checks.

[mathematicalmichael]

does seem like github actions may be disabled for PRs on this repo, I expected it to kick off as a check with this PR

[mathematicalmichael]

or it could be that I need to change the conditions in the file...

[davidrmiller]

In Settings->Actions, the option "Allow all actions" is enabled. Are there other relevant settings?

[mathematicalmichael]

@davidrmiller that's the one, I figured out it was the config. Now as to why it's still failing... let's see.

[mathematicalmichael]

oh interesting. it is now failing because the image has a user whose permissions do not match those of the environment in which github actions is running, and thus the obj directory cannot be written to. I'll get a fix in shortly.

[mathematicalmichael]

@davidrmiller setting explicit group/user identification in the github action step did the trick. it's always a little tricky to deal with users/groups when mounting folders. I'm user / group 1000 on nearly everything and since the darwin user I create in the docker image is also the first user, they had the same ids. github actions being more sophisticated means these assumptions come to light.

[mathematicalmichael]

now you can actually have compilation verification on pull requests! how fun =D (sorry I didn't check this all earlier)

[davidrmiller]

This is awesome, Thanks @mathematicalmichael !