davidrmiller / biosim4

Biological evolution simulator
Other
3.1k stars 435 forks source link

Updated Ubuntu version #85

Closed stepgrif closed 1 year ago

stepgrif commented 1 year ago

ubuntu:impish-20211102 is no longer available, updated to ubuntu:latest to make it more robust in the future

mathematicalmichael commented 1 year ago

Hi. thank you for bringing this to our attention!

The docker image disappeared? That's highly unexpected.

I just tried docker pull ubuntu:impish-20211102 and it worked fine, so I'm not sure what you mean by "no longer available"

If you're using a non-docker container runtime, you may consider prepending the image name with docker.io/ to make explicit where the image should be sourced from (though the Dockerfile already does this).

Part of the motivation for pinning the tag was to keep a stable image (rather than using the latest tag). If you're proposing a change in image, I'd say that pinning to a more recent 2022 release is still preferable than using latest.

stepgrif commented 1 year ago

Hey, No problem, I do see your rational. It appears impish repos are not available anymore. I've included the log below. Impish reaches End of Life on July 14 2022.

  default: E: The repository 'http://security.ubuntu.com/ubuntu impish-security Release' does not have a Release file.
    default: E: The repository 'http://archive.ubuntu.com/ubuntu impish Release' does not have a Release file.
    default: E: The repository 'http://archive.ubuntu.com/ubuntu impish-updates Release' does not have a Release file.
    default: E: The repository 'http://archive.ubuntu.com/ubuntu impish-backports Release' does not have a Release file.
    default: The command '/bin/sh -c apt-get update && apt-get install -yqq     build-essential         dumb-init      python3-pip      && apt-get clean        && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100
    default: the input device is not a TTY
    default:

I think the packages you use are well supported and more likely to remain the latest ubuntu LTS releases

I'm happy to investigate using any of the below if it would help?

18.04, bionic-20221019, bionic
20.04, focal-20221019, focal
22.04, jammy-20221101, jammy, latest
14.04, trusty-20191217, trusty
16.04, xenial-20210804, xenial 

Thank you for making this project available, I really enjoy showing it to my friends to help truly understand evolution.

Kind regards,

Stephen

davidrmiller commented 1 year ago

@stepgrif @mathematicalmichael Thanks so much for reporting and investigating this. Additional reviews are welcome since I'm not a docker expert. Thanks!

mathematicalmichael commented 1 year ago

ohh I see, the image is still available but the repos are down. That would track with october having just passed…

yes it would help if you could find a more recent image. It had to be impish when this repo was created because 20.04 had the wrong library versions. So I’d start with 22.04 up. go ahead and update the PR with the pinned tag you find works.

Much appreciated!

davidrmiller commented 1 year ago

I see no suggestions for a specific version, so I've accepted the proposed changed to "latest."