davidrmiller / neural2d

Neural net optimized for 2D image data
MIT License
142 stars 69 forks source link

Remove the use of "using namespace std;" in the webserver module. #13

Closed jeandudey closed 9 years ago

jeandudey commented 9 years ago

In this commit i made these changes:

davidrmiller commented 9 years ago

Thanks for doing this clean-up. I tested it with g++ on Linux and Cygwin on Windows.

In webserver.cpp on line 151, ref() is now undefined, so we should change that to std::ref().

Also, std::ref() is declared in <functional>. I forgot to #include that header, so some other system header must be including it behind the scenes. To be pedantically correct, we could add #include <functional> to webserver.cpp.

Please feel free to submit an updated pull request, and then I will apply it without modification. Alternatively, I can apply the pull request with modifications, and I'll try to make sure your name appears in the "author" field.

jeandudey commented 9 years ago

I will make the changes. Thanks for the feedback

davidrmiller commented 9 years ago

Thanks for the contribution!