search

davidsansome / tsurukame

Tsurukame is an unofficial WaniKani app for iOS. It helps you learn Japanese Kanji.
https://tsurukame.app
Apache License 2.0
252 stars 58 forks source link

Critical Bugfix: crash when する appears #637

Closed marciska closed 1 year ago

marciska commented 1 year ago

Hotfix for #636.

Added an additional if statement so app doesn't crash when する appears.

Issue before was that する is recognised as a suruVerb, but is omitted since it is a suffix. In the code, there is then an empty string, resulting in a crash. The above fix checks if it is the kana-word する, and then does NOT omit it.

davidsansome commented 1 year ago

Thanks for doing this! I've pushed 304f02a50a73e74d3ab8ec79f2f39194e6a255b2 instead which is I think a more general solution to the bug!