davidsansome / tsurukame

Tsurukame is an unofficial WaniKani app for iOS. It helps you learn Japanese Kanji.
https://tsurukame.app
Apache License 2.0
261 stars 61 forks source link

Add Artwork by @AmandaBear to Subject #653

Closed tallerasaf closed 9 months ago

tallerasaf commented 1 year ago

Add helpful artwork for a subject.

WK Mnemonic “Art” for Kanji Levels 1-7 (Radical Levels 1-10)

Based on this userscript, by @Sinyaven: https://greasyfork.org/en/scripts/418774-wanikani-mnemonic-artwork

@AmandaBear consent: Feel free to do whatever you want with my images. I only made them for fun and to help others learn the mnemonics. Go right ahead. I give my full permission to use my images.  I waive all rights to all my WaniKani radical and kanji drawings, including all those posted and linked at WK Mnemonic "Art" for Kanji Levels 1-7 (Radical Levels 1-10) , under the CC0 public domain dedication (Creative Commons — CC0 1.0 Universal).

Example ScreenShot

tallerasaf commented 1 year ago

@indirect @UInt2048 @davidsansome Can you take a look? Thanks!

aaron-meyers commented 9 months ago

@tallerasaf @davidsansome @UInt2048 I just saw this in the TestFlight build and turned it on but couldn't get it to work on my iPhone. Running latest iOS, iPhone 12 mini. Not sure what's going on.

That said, I'd like to propose that Tsurukame adopt the much broader AI mnemonic images project that has been ongoing for the last 1+ year. This project has already produced hundreds of images and has had a lot of renewed interest with the release of the highly capable DALL-E 3 image generation model. The community post about the project is here (with link to the Discord server for submitting and voting on images): https://community.wanikani.com/t/new-volunteer-project-were-using-ai-to-create-mnemonic-images-for-every-radical-kanji-vocabulary-come-join-us/58234

And the userscript that implements it is here (also in the community post of course): https://greasyfork.org/en/scripts/448713-wanikani-ai-mnemonic-images

It should be a fairly small change to get subject images from the project's CDN instead of the hard-coded list in this PR. I can work on this myself although it might take some time as I haven't done iOS development before. But if someone else here is interested please go for it.

Also I'd love to see this support an offline download, similar to how Tsurukame supports downloading fonts and audio. I don't think it would be terribly efficient to download every subject image individually so I would raise this with the project admins to consider adding a zip download that packages subject images by level (e.g. separate packages for levels 1-10, 11-20, etc like Tsurukame appears to use for audio).

Thoughts? I've been thinking about doing this in Tsurukame for the last few months but haven't found the time yet to look into it seriously. I also wasn't sure whether there would be interest in supporting a community (rather than official) source like this but when I saw this new feature mentioned I figured it was a good time to bring this up :)

tallerasaf commented 9 months ago

@davidsansome @aaron-meyers

Fix this in PR - "Fix network issue and screen size issue for "Add ArtWork by @AmandaBear to Subject #653""

aaron-meyers commented 9 months ago

I think you meant https://github.com/davidsansome/tsurukame/pull/685

davidsansome commented 9 months ago

That said, I'd like to propose that Tsurukame adopt the much broader AI mnemonic images project that has been ongoing for the last 1+ year.

I'd be supportive if somebody wants to implement that in Tsurukame!

Also I'd love to see this support an offline download, similar to how Tsurukame supports downloading fonts and audio. I don't think it would be terribly efficient to download every subject image individually so I would raise this with the project admins to consider adding a zip download that packages subject images by level (e.g. separate packages for levels 1-10, 11-20, etc like Tsurukame appears to use for audio).

Agreed, I'd prefer to make these available offline. I actually changed the way Tsurukame does offline audio back in 20f5c8c014cb3e3bca2b2b04a0edacdd09240fd9 - it doesn't use the bundles any more because they got out of date as Wanikani added new audio files and voice actors. Now it downloads all the individual files from Wanikani (for all levels up to your current level + 1) in parallel. I imagine we'd do something similar for the artwork as well. It ends up being pretty fast if you do enough requests in parallel.

tallerasaf commented 9 months ago

@davidsansome I can implement it when I have time, I think it's a very nice feature to add.

@aaron-meyers You can create an issue for this feature? And I will create a PR when I have time.

aaron-meyers commented 9 months ago

Yeah just got back from a wedding. Will try to create the new issue over the weekend.

aaron-meyers commented 9 months ago

Ok created a meta-feature #689 and sub-features to capture the work needed. Thanks!