search

davidsansome / tsurukame

Tsurukame is an unofficial WaniKani app for iOS. It helps you learn Japanese Kanji.
https://tsurukame.app
Apache License 2.0
261 stars 61 forks source link

"Ask again later" resulting in incorrect items being marked correct #669

Open charmingtoad opened 1 year ago

charmingtoad commented 1 year ago

I have Anki mode turned on, and also have meanings and readings paired together with meanings first. I think an item was marked as burned that shouldn't have been.

Steps to reproduce:

For a particular item, 1) Answer a meaning incorrectly 2) Mark it as incorrect 3) The same item comes up again immediately. Mark "ask again later" 4) When the item comes up later, mark the meaning and reading as correct Result: The "burned" pop-up appeared Expected Result: I do not think this item should have been burned since I got it incorrect the first time.

tarcisiotm commented 10 months ago

Hey @charmingtoad, I am not the maintainer of this project but I might be able to offer some insight, as I implemented the combine reading + meaning functionality you mentioned, for Anki Mode.

I agree with you, it would indeed be great if the system could remember a mistake was made for the item. It seems that this happens by design. In code, for Anki mode, the app manipulates data differently, for example, when the user marks "Ask again later", the code does the same, so even if the answer was marked wrong before, the system will overwrite wrong with ask again later.

If I may offer a workaround, in case you want to make sure that answer is marked as wrong, when the item pops up again, you could mark it as incorrect again, then immediately as correct. That's what I do.

charmingtoad commented 10 months ago

Thanks, that is helpful to know!