search

davidsansome / tsurukame

Tsurukame is an unofficial WaniKani app for iOS. It helps you learn Japanese Kanji.
https://tsurukame.app
Apache License 2.0
249 stars 58 forks source link

Lesson picker text is covered by transparent nav bar #707

Closed Deadpikle closed 2 months ago

Deadpikle commented 2 months ago

The nav bar is transparent, and the table view doesn't account for the text. See picture:

Simulator Screenshot - iPhone SE (3rd generation) - 2024-04-29 at 11 15 15

This issue was introduced in 599e95f.

Deadpikle commented 2 months ago

I think the issue is introduced here (or at least in this commit):

https://github.com/davidsansome/tsurukame/commit/599e95f89e811c108202d9d9c4c1b20435022226#diff-e1017a470ae08f327112d351e0f89682d4dc424a2d64bd524410ee6f606d76ceR252-R258

Not returning the 12 there fixes the issue, as does model.add(section: " " instead of model.add(section: "" in the LessonPickerViewController.

I'm not sure what the optimal fix is here nor why the UpcomingReviewsViewController view controller does not exhibit the same problem. It seems that there isn't a header, so it's fine to not really be returning a header size logically, but that causes other issues, so I'm not sure what the overall issue is.