search

davidsansome / tsurukame

Tsurukame is an unofficial WaniKani app for iOS. It helps you learn Japanese Kanji.
https://tsurukame.app
Apache License 2.0
249 stars 58 forks source link

Fix macOS issue where text input gets highlighted during reviews #709

Closed twocentstudios closed 2 months ago

twocentstudios commented 2 months ago

Fixes #706 Related PR: #186

becomeFirstResponder was added in https://github.com/davidsansome/tsurukame/pull/186 to ReviewViewController.animationDidStop as a workaround specifically for macOS (starting at 10.15). At that time, the answerTextField would lose focus after each answer.

With current macOS (14.4), answerTextField no longer loses focus, but having the additional becomeFirstResponder triggered on animationDidStop causes the existing contents of answerTextField to be selected.

In my testing, the behavior of iOS on iPhone is not affected by this change either way.