davidsansome / tsurukame

Tsurukame is an unofficial WaniKani app for iOS. It helps you learn Japanese Kanji.
https://tsurukame.app
Apache License 2.0
249 stars 58 forks source link

Bug: offline refreshing removes all local data #728

Closed Arzorth closed 4 days ago

Arzorth commented 6 days ago

First of all, congratulations for the great job done in the 1.32 update, it is amazing how you guys managed to improve an app that was already fantastic.

Second, this error happens from before 1.32 update, it is jus that, with the new update, I felt motivated to report it :)

Now, going to the topic: the app removes all the local data as the first step when doing a full refresh, which is fine when you have connection but it leaves the app in a void state if the connection failed.

I made a video to show it: https://github.com/davidsansome/tsurukame/assets/17315806/8be9e027-e26a-4769-9ab9-e93652af624f

Context: I normally travel a lot from (surprise) Japan to my home country (Spain), and I love to study kanjis during the flight, for this Tsurukame is the best app ever. But if I pull by mistake the screen down (it happened during a flight 🫠), I can't use the app for the rest of the flight (which is quite long! haha).

Do you guys find it doable to perform a network check before removing the data? Or maybe saving it as a backup and in case the update fails, re-importing it from the local backup?

I hope it is something quick!

Best regards, Jose (ホセ)