davidsansome / tsurukame

Tsurukame is an unofficial WaniKani app for iOS. It helps you learn Japanese Kanji.

https://tsurukame.app

Apache License 2.0

264 stars 63 forks source link

refactor(settings): rename 'batch size' property to be more descriptive #759

Closed zjgoodman closed 2 weeks ago

zjgoodman commented 2 months ago

closes #745

renames the 'review batch size' property to reflect the actual behavior that it controls so that it's more obvious to users what they're actually changing when they tweak this setting

I landed on Reviews Between Meaning & Reading which I feel is extremely descriptive, yet concise and clear. I don't see how you could misunderstand the behavior of this property now.

Settings screen

Settings detail screen

zjgoodman commented 2 months ago

@davidsansome this one is ready for your review

zjgoodman commented 2 months ago

@davidsansome whenever you get a chance can you please take a look at this one? Thank you 🙏

zjgoodman commented 1 month ago

@davidsansome lemme know if you have any questions about this one 👌

davidsansome commented 2 weeks ago

Sorry for the seriously long delay on this one!