search

davidsantiago / clojure-csv

A library for reading and writing CSV files from Clojure
187 stars 35 forks source link

Added support for CR as line-end char #29

Open kriyative opened 8 years ago

davidsantiago commented 8 years ago

What is this for? The end-of-line is already configurable with the :end-of-line argument in both reading and writing.

kriyative commented 8 years ago
  1. CR is the line-end convention used by Excel on OSX for CSV exports, so it seems to be quite common in the wild
  2. end-of-line does allow passing in CR, but that requires the caller to know a-priori the convention used in the file being read
  3. Adding a layer around clojure-csv to pre-test the line-end seems excessive, especially when clojure-csv is doing that anyway

Perhaps, I've missed something about the intended use of end-of-line ... would be happy to understand.

Cheers.

Boubalou commented 6 years ago

That is exactly what I was about to code. Well, any chance it gets merged so we do not have to fork it ourself.