search

davidsantiago / clojure-csv

A library for reading and writing CSV files from Clojure
187 stars 35 forks source link

Quoting on comma instead of *delimiter* #4

Closed i0cus closed 13 years ago

i0cus commented 13 years ago

Regarding line 148 of clojure-csv.core (inside needs-quote? function): need for quoting is determined using comma -- default CSV delimiter -- but at the same time you allow rebinding with delimiter... So in the end I am using different delimiter and my fields with "," are still getting quoted -- which is unexpected and breaks viewing resulting file in Excel, which in turn tripped me badly yesterday.

Would you consider changing this?

davidsantiago commented 13 years ago

Of course I'd change this, it's a bug! :) My work with CSVs only happens on comma-delimited ones, so I'm afraid the other cases haven't seen as much testing. Sorry this caused you some pain yesterday, but I just pushed up 1.2.3 that should have that fixed. Let me know if you find anything else.

i0cus commented 13 years ago

Thanks! I've actually had two other things (dependency change and enhancement) on my mind, will follow with separate tickets after I get some rest.