search

davidsbatista / BREDS

"Bootstrapping Relationship Extractors with Distributional Semantics" (Batista et al., 2015) in EMNLP'15 - Python implementation
https://www.aclweb.org/anthology/D15-1056
GNU Lesser General Public License v3.0
145 stars 40 forks source link

Clarification of pattern.py line 18 #13

Closed zqyeo closed 5 years ago

zqyeo commented 5 years ago

Line 18: if tuple is not None: Line 19: self.tuples.add(t)

tuple is a Python keyword for the tuple class, and the statement in Line 18 will always return True.

Should it be:

if t is not None: self.tuples.add(t)

? Thank you.

davidsbatista commented 5 years ago

You are totally correct, this was a distraction/silly thing, thanks once again for keeping an eye for this kind of bugs. I will submit a correction in a few minutes.

zqyeo commented 5 years ago

No problem! Great work by the way.

You are totally correct, this was a distraction/silly thing, thanks once again for keeping an eye for this kind of bugs. I will submit a correction in a few minutes.