search

davidscn / matrix-free-dealii-precice

A matrix-free high performance solid solver for coupled fluid-structure interactions
GNU Lesser General Public License v3.0
8 stars 6 forks source link

Included missing step to add a new test case #66

Closed simrnjandu closed 6 months ago

simrnjandu commented 6 months ago

Please have a look. /include/parameter/parameter_handling.h also needs to be updated when adding new test cases.

davidscn commented 6 months ago

Thanks @simrnjandu ! While this is absolutely true, I identified this only later as a tedious mistake. The check performed in the parameter handler is a redundancy of the case selector. Instead of merging your documentation changes, would you mind removing the pattern selector

https://github.com/davidscn/matrix-free-dealii-precice/blob/0d1fd01bfbd4a5f48a70541e4e5720a610f1905c/include/parameter/parameter_handling.h#L128-L130

and replace it by Pattern::Anything()?

simrnjandu commented 6 months ago

Sure @davidscn , I will create another PR with the said changes.