search

davidshimjs / jaguarjs-jsdoc

A Template of jsdoc for jaguar.js project
MIT License
218 stars 136 forks source link

Changes I made to support @interface types #47

Closed ehallander9591 closed 7 years ago

ehallander9591 commented 7 years ago

Not sure if I am doing this right as I never submitted a pull request for anything yet.

I had some jsdocs that used @interface, and that part wasn't rendering at all, and since I liked this template better than some of the others I looked at, I gave it shot to see about getting the @interface implemented.

This is what I came up with, and it seems to satisfy the behavior I was getting when the @interface tags were implemented as @typedef tags. So I am happy. Perhaps this is good. If there is something else that needs to be done, please ask.

interface.zip

Cheers

ehallander9591 commented 7 years ago

I honestly have no idea if this pull request has any merit. The responses look like automatic responses that indicate failure, but that could be because I do not have write access to this repository, which I am not asking for. My changes appear to be in the zip file attached, and they seem failure innocuous and trivial to apply.

If there is way that I should have executed this pull request, so that it is proper, then let me know, and I will follow those instructions.

Cheers

ehallander9591 commented 7 years ago

I forked my own branch off pixijs which is a fork off this branch, and I made a pull request to that version which is the referenced version from npmjs.org.