search

davidshimjs / qrcodejs

Cross-browser QRCode generator for javascript
MIT License
13.55k stars 4.76k forks source link

Transpiled Code? #138

Open hdon opened 6 years ago

hdon commented 6 years ago

What's going on here? Why such a radical departure from the style of the rest of the source code?

https://github.com/davidshimjs/qrcodejs/blob/04f46c6a0708418cb7b96fc563eacae0fbf77674/qrcode.js#L87-L152

hdon commented 6 years ago

Or maybe reverse-engineered optimized code?

ghost commented 5 years ago

I am curious as well. I tried finding the source.

bleetsheep commented 2 years ago

Same here. Minified code in the "source" gives me a reverse engineering vibe, or at least not welcoming to reading, verifying, or contributing, so I'm not going to use this library.

Edit: the d-project.com website of the original author is down (seems to have gone down like yesterday) but through the wayback machine I could retrieve it, saw that it moved and could follow a link to their github. This seems to be where the code came from: https://github.com/kazuhikoarase/qrcode-generator/blob/b95b52e887f832ebff0a9ec93c08f2e83d95ec92/js/qrcode.js Why it was minified and then pasted in the middle of this project's code, no idea.