davidskalinder / mpeds-coder

MPEDS Annotation Interface
MIT License
0 stars 0 forks source link

Delete unused convertIDToPublication and _pubCount functions from controller #114

Open davidskalinder opened 3 years ago

davidskalinder commented 3 years ago

convertIDToPublication(): Extracts the pub name out of a Solr ID, by position it looks like. Called only once, in _pubCount(), the only call to which is commented out and which has a note in its header saying that it should be reimplemented in pandas. So, looks like this both convertIDToPublication() and _pubCount() could be removed altogether! Though not sure whether the Solricide branch is the best place for it or not...

Originally posted by @davidskalinder in https://github.com/davidskalinder/mpeds-coder/issues/71#issuecomment-747738989