Open davidskalinder opened 3 years ago
@alexhanna, do you have any thoughts about whether it'd be better to simply take the HTML out of the template or to also remove the soon-to-be-unused logic from the JS and controller files? Here are some ups and downs I can think of about removing AMAP of the underlying logic:
simply take the HTML out of the template
This part is done at 8248e271a1ee4 btw
@alexhanna sez cut baby cut.
Hey @alexhanna another quick question for you on this: it looks like generate-coder-table.py
queries the table 1000 rows at a time and writes the output one row at a time, whereas the code in the controller queries the whole table and writes the whole result all at once.
Do we know whether running the chunked approach from the UI button would prevent it from crashing?
If so, then it seems like I should only disable the button HTML and get rid of the bad controller code, leaving the JS as it is so it'll be easy to revive by just swapping the chunked function into the controller?
Do we know whether running the chunked approach from the UI button would prevent it from crashing?
We almost certainly do now: https://github.com/davidskalinder/mpeds-coder/issues/122#issuecomment-846282279
If so, then it seems like I should only disable the button HTML and get rid of the bad controller code, leaving the JS as it is so it'll be easy to revive by just swapping the chunked function into the controller?
If that. It might turn out to be easy enough to get the chunked export to work that we can just leave the button there. This should depend on #122 and comment out the button if #122 gets paused or leave it in and forget about this issue if #122 results in a working export.
As discussed in #122, this button seems to crash Apache's Python instance when run from any MAI whose
coder_event_creator
table (probably) reaches a certain size, and so amounts to a "temporarily crash server" button.Both of the live DBs now seem to have reached that point, and so this button only accomplishes two things that I can think of:
So unless we are really desperate for excitement, I don't think there's any reason to leave it in. Whether to rebuild it properly somewhere else is another question so I'll open another issue for that.