davidskalinder / mpeds-coder

MPEDS Annotation Interface
MIT License
0 stars 0 forks source link

Fix sawed-off date columns when font is big #98

Open davidskalinder opened 4 years ago

davidskalinder commented 4 years ago

@olderwoman, @matthewsmorgan, and @alexhanna probably care about this one:

When the font size is big enough (probably somewhere around 140-150% depending on other settings?), columns of dates can get sawed off of calendar widgets entirely.

Note that this is different from #37: this time, the entire column gets sawed off, not just the backing.

Workarounds are that the coders can either type the date from the missing column or temporarily make their font smaller to see the column.

I'm thinking this shouldn't be an ultra-high priority given the ease of the workaround? But @olderwoman / @matthewsmorgan, feel free to overrule me if you think this will screw things up too badly for the pass 1 coders.

@alexhanna, this might be an unwanted side effect of #94? Although there should be a way to fix it properly without having to fix the block size...

davidskalinder commented 4 years ago

Incidentally, I should mention that one of the coders reported this, though it sounds like she's okay to use the workarounds for now. So at least one person has been affected by this in the wild and that one person knows how to work around it.

olderwoman commented 4 years ago

I’ll defer to Morgan. Working around it seems ok to me

From: davidskalinder notifications@github.com Sent: Thursday, June 18, 2020 3:17 PM To: davidskalinder/mpeds-coder mpeds-coder@noreply.github.com Cc: PAMELA E OLIVER pamela.oliver@wisc.edu; Mention mention@noreply.github.com Subject: [davidskalinder/mpeds-coder] Fix sawed-off date columns when font is big (#98)

@olderwomanhttps://github.com/olderwoman, @matthewsmorganhttps://github.com/matthewsmorgan, and @alexhannahttps://github.com/alexhanna probably care about this one:

When the font size is big enough (probably somewhere around 140-150% depending on other settings?), columns of dates can get sawed off of calendar widgets entirely.

Note that this is different from #37https://github.com/davidskalinder/mpeds-coder/issues/37: this time, the entire column gets sawed off, not just the backing.

Workarounds are that the coders can either type the date from the missing column or temporarily make their font smallerhttps://support.mozilla.org/en-US/kb/font-size-and-zoom-increase-size-of-web-pages#firefox:linux:fx77 to see the column.

I'm thinking this shouldn't be an ultra-high priority given the ease of the workaround? But @olderwomanhttps://github.com/olderwoman / @matthewsmorganhttps://github.com/matthewsmorgan, feel free to overrule me if you think this will screw things up too badly for the pass 1 coders.

@alexhannahttps://github.com/alexhanna, this might be an unwanted side effect of #94https://github.com/davidskalinder/mpeds-coder/issues/94? Although there should be a way to fix it properly without having to fix the block size...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/davidskalinder/mpeds-coder/issues/98, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADBJJ5PMZIU3OWXSZTPC3QDRXJY33ANCNFSM4OCDXJLQ.

matthewsmorgan commented 4 years ago

If this isn't affecting many people and they know of the workaround, then I do not see this as high-priority. I have been doing a good amount of Pass 1 coding in recent weeks and have never come across this issue.

On Wed, Jun 24, 2020 at 9:19 AM olderwoman notifications@github.com wrote:

I’ll defer to Morgan. Working around it seems ok to me

From: davidskalinder notifications@github.com Sent: Thursday, June 18, 2020 3:17 PM To: davidskalinder/mpeds-coder mpeds-coder@noreply.github.com Cc: PAMELA E OLIVER pamela.oliver@wisc.edu; Mention < mention@noreply.github.com> Subject: [davidskalinder/mpeds-coder] Fix sawed-off date columns when font is big (#98)

@olderwomanhttps://github.com/olderwoman, @matthewsmorgan< https://github.com/matthewsmorgan>, and @alexhanna< https://github.com/alexhanna> probably care about this one:

When the font size is big enough (probably somewhere around 140-150% depending on other settings?), columns of dates can get sawed off of calendar widgets entirely.

Note that this is different from #37< https://github.com/davidskalinder/mpeds-coder/issues/37>: this time, the entire column gets sawed off, not just the backing.

Workarounds are that the coders can either type the date from the missing column or temporarily make their font smaller< https://support.mozilla.org/en-US/kb/font-size-and-zoom-increase-size-of-web-pages#firefox:linux:fx77> to see the column.

I'm thinking this shouldn't be an ultra-high priority given the ease of the workaround? But @olderwomanhttps://github.com/olderwoman / @matthewsmorganhttps://github.com/matthewsmorgan, feel free to overrule me if you think this will screw things up too badly for the pass 1 coders.

@alexhannahttps://github.com/alexhanna, this might be an unwanted side effect of #94https://github.com/davidskalinder/mpeds-coder/issues/94? Although there should be a way to fix it properly without having to fix the block size...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub< https://github.com/davidskalinder/mpeds-coder/issues/98>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/ADBJJ5PMZIU3OWXSZTPC3QDRXJY33ANCNFSM4OCDXJLQ>.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/davidskalinder/mpeds-coder/issues/98#issuecomment-648850424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN4I3JQ55VLWJZUYCF637I3RYIDQVANCNFSM4OCDXJLQ .

davidskalinder commented 4 years ago

Sounds good, thanks both!