search

davidson-consulting / diff-jjoules

diff-jjoules is a tool to run in your continuous integration to measure the impact of commits on the energy consumption of the program :seedling:
GNU General Public License v3.0
4 stars 5 forks source link

fix: bugs report in Configuration class #30

Closed dendritett closed 2 years ago

dendritett commented 2 years ago

Fixing bugs reported by Sonar #27 ・Do something with the "boolean" value returned by "delete".

I've tried using java.nio.file.Files#deleteIfExists, what do you think? If there are any problems, please point them out.

danglotb commented 2 years ago

LGTM! Thank you! :confetti_ball:

Do you think we could add a test or something to throw this exception or it is difficult to set up?

dendritett commented 2 years ago

LGTM! Thank you! 🎊

Do you think we could add a test or something to throw this exception or it is difficult to set up?

Thanks for the review! I created a simple test that throws this exception, what do you think? If there are any problems, please point them out.

danglotb commented 2 years ago

Thank you, great job :smile: