search

davidson-consulting / diff-jjoules

diff-jjoules is a tool to run in your continuous integration to measure the impact of commits on the energy consumption of the program :seedling:
GNU General Public License v3.0
4 stars 5 forks source link

fix: bugs report in JJoulesProcessor class #35

Closed dendritett closed 2 years ago

dendritett commented 2 years ago

Fixing bugs reported by Sonar #27 ・Call "Optional#isPresent()" or "!Optional#isEmpty()" before accessing the value.

I haven't created any tests here, since the existing tests cover this area.

dendritett commented 2 years ago

As the amount of source code has decreased, the percentage of the total that we have covered has decreased.:sob:

danglotb commented 2 years ago

Thanks! What I learned is that the checkstyle is also executed in the test CI while it should not since it has its own GitHub actions

We should skip the checkstyle when testing.