--mode=plan is destructive

davidstanke / haystacker

A tool for finding log entries in Google Cloud Logging

Apache License 2.0

1 stars 0 forks source link

Open Deleplace opened 3 years ago

Deleplace commented 3 years ago

The correct command order is (1) plan, (2) query, (3) aggregate. The step (2) may take a long time.

If the user accidentally runs (1) plan, (2) query, (1) plan , then all the precious data from step (2) is destroyed without a warning.

Deleplace commented 3 years ago

IMO it would be fine to have --mode=plan fail when the matches folder is not empty.

Shall I make a PR?