Made init public and added test for setting callBackqueue on transport

davidstump / SwiftPhoenixClient

Connect your Phoenix and iOS applications through WebSockets!

MIT License

507 stars 147 forks source link

Made init public and added test for setting callBackqueue on transport #162

Closed eoinoconnell closed 4 years ago

eoinoconnell commented 4 years ago

Based off #159 + #160

I needed to be able to set the callback queue on the transport manually so made the init public.

Not 100% on the test as you need to manually call connect to populate the connection so you may want that moved elsewhere.

When looking at #159 more the heartbeat timers were not working so the socket server would close the connection. This PR also updates the heartbeat timer to use its own thread in order to resolve that issue.

AndrewSB commented 4 years ago

this looks great, I'm running into an issue that this fixed. Can I do anything to help get this merged in?

AndrewSB commented 4 years ago

I've rebased this against master and opened a PR against @8bytes' repository

dsrees commented 4 years ago

Sorry guys for being so delayed on this. I was finally able to get around to review this. It looks good, thanks for making these changes @eoinoconnell

dsrees commented 4 years ago

I've manually merged this PR into master

eoinoconnell commented 4 years ago

My pleasure, thanks for the library! 👍

dsrees commented 4 years ago

v1.3.0 is released with these changes. let me know if you have any issues!

AndrewSB commented 4 years ago

awesome! Thanks a bunch 😄