davidstutz / bootstrap-multiselect

JQuery multiselect plugin based on Twitter Bootstrap.
https://davidstutz.github.io/bootstrap-multiselect/
Other
3.66k stars 1.99k forks source link

Original SELECT element shown when used in a Knockout IF clause #1235

Open maverick543 opened 2 years ago

maverick543 commented 2 years ago

When you use a multiselect control with in a knockout IF binding, it will show the original SELECT element when you switch from a IF true to an IF false condition. This is caused by the destroy method implementation. This explicitly shows the original select element which is incorrect behavior.

https://github.com/davidstutz/bootstrap-multiselect/blob/dedc507d3c17ed5953f1ff17d9dc99e8625b8830/dist/js/bootstrap-multiselect.js#L1380

s-eckard commented 1 year ago

As far as I can see there is no need for this line. Therefore I will remove it and this behavior will be fixed with the next release.