search

davidtakac / bura

Modern weather app with graphs and thoughtful data visualization
GNU General Public License v3.0
230 stars 26 forks source link

Add monochrome icon for material you theming #47

Closed mark-pitblado closed 5 months ago

mark-pitblado commented 5 months ago

Looking to add support for android themed icons supported in Android 13+ (if you are interested). I thought it would be a quick addition of a monochrome version of the foreground drawable, however this doesn't seem to be the complete fix, at least on my emulator.

It may have something to do with Theme.AppCompat, however I am not sure. Putting this up as a draft in case anyone else knows of a quick fix to get it the rest of the way there. I'll come back and work on it some more when I have time.

Docs: https://developer.android.com/develop/ui/views/launch/icon_design_adaptive

283375 commented 5 months ago

The ic_launcher_round.xml also needs a <monochrome> entry, looks like you've missed it ;)

By adding the same <monochrome android:drawable="@drawable/ic_launcher_monochrome"/> to ic_launcher_round.xml, the monochrome icon works well, and here's a preview on a real device

mark-pitblado commented 5 months ago

Awesome! Thank you so much, and obvious in hindsight. Should be good to go now!