davidteren / lpx_links

Gets the additional content download links for Logic Pro X
http://davidteren.github.io/lpx_links
110 stars 28 forks source link

Cannot run install command #18

Open bedmunds97 opened 1 year ago

bedmunds97 commented 1 year ago

It is coming up with: 'sudo: ./download_install.sh: command not found' Any thoughts?

thekungfuspider commented 1 year ago

Yes, the instructions were written by two people who may not have been in sync with one another. I created a fork of this repository and am in the process of fixing a couple things.

@davidteren - I hope you're still around for review! Also, I'm noticing that there are 10+ forks of this repo in which advances are being made. We may want to do a round robin and collect pull requests to bring well tested features / bugfixes that improve the product back into master here. I'd be happy to help with that process.

davidteren commented 1 year ago

@thekungfuspider please go ahead. :ok_hand:

xCessivePressure commented 1 year ago

Hi,

Please forgive my noobishness, but I believe I have an issue related to this.

I've used -d to specify my prefered download folder following the suggestion indicated in the download command. However, I cannot seem to make the install command work because the files are not in the default ~/Downloads/ folder. I've tried specifying the folder where i've downloaded everything, but I can't make it work.

Help?

xCessivePressure commented 1 year ago

Hi,

Please forgive my noobishness, but I believe I have an issue related to this.

I've used -d to specify my prefered download folder following the suggestion indicated in the download command. However, I cannot seem to make the install command work because the files are not in the default ~/Downloads/ folder. I've tried specifying the folder where i've downloaded everything, but I can't make it work.

Help?

Think i've figured it out. Downloaded the download_install.sh and modified the command thus:

!/bin/bash

cd /NAME OF FOLDER/ while read -r line; do name="$line" echo "Downloading $name..." curl -O $name done < $1

for pkg in /NAME OF FOLDER/*.pkg; do echo "Installing $pkg file..." sudo installer -pkg $pkg -target / done

Then I copied and pasted in terminal.

It is now installing, but it is not installing in the folder where I downloaded the files. I guess i'll just move the library from Logic's menu.

AlftheElf commented 1 year ago

The instructions are very confused, yes.

I downloaded 60GB+ of the packages, but running the download_install.sh script overwrites the .pkg files which means they can't be installed, because they now contain the wrong data. I then had to redownload all the packages a second time.

Instead the instructions need to be to download with aria2c, and then the download_install.sh script needs to be changed to:

#!/bin/bash
for pkg in $1/*.pkg; do
    echo "Installing $pkg file..."
    installer -pkg $pkg -target /
done

You can then run sudo ~/Downloads/lpx_links/app/download_install.sh ~/Downloads/logic_content to install the .pkg files. They are installed to the root by default. Change -target / to another volume if needed.

Then check the packages have been installed by checking /Library/Application\ Support. Files are added to folders named Logic and GarageBand.

bedmunds97 commented 1 year ago

You guys are literal gods to me lmao, I'm so useless at computer stuff. So should that work now @AlftheElf if I copy your instructions into the terminal? Will that run the installation autonomously?

AlftheElf commented 1 year ago

You guys are literal gods to me lmao, I'm so useless at computer stuff. So should that work now @AlftheElf if I copy your instructions into the terminal? Will that run the installation autonomously?

Yes it should install autonomously. Have you successfully downloaded the packages using aria2c first?

Also, don't copy this script into the terminal:

#!/bin/bash
for pkg in $1/*.pkg; do
    echo "Installing $pkg file..."
    installer -pkg $pkg -target /
done

You need to edit the ~/Downloads/lpx_links/app/download_install.sh file for that part. Then yes, run sudo ~/Downloads/lpx_links/app/download_install.sh ~/Downloads/logic_content and it should install everything.

mkman7 commented 1 year ago

Hi, I have installation problem, But I also tried to install pkg file by run it manually, then I got another error msg. any ideas? Thx.

Screen Shot 2023-04-15 at 13 40 58

Screen Shot 2023-04-15 at 13 38 44

AlftheElf commented 1 year ago

@mkman7 Did you edit the download_install.sh before running it? When I ran the original version it gave me the same error you have, and can’t even be installed manually.

If you replace all the code in the script with this,

#!/bin/bash
for pkg in $1/*.pkg; do
    echo "Installing $pkg file..."
    installer -pkg $pkg -target /
done

it won’t run the part which corrupts the packages. If you already ran the download_install.sh script without editing it first, you will have to download everything again, which is what I had to do.

mkman7 commented 1 year ago

I got it now. Thank you !

davidteren commented 1 year ago

Thanks to @AlftheElf this PR should solve the issue.