search

davidtheclark / react-aria-modal

A fully accessible React modal built according WAI-ARIA Authoring Practices
http://davidtheclark.github.io/react-aria-modal/demo/
MIT License
1.03k stars 96 forks source link

Support for React 17/18 #126

Open LukaszGrela opened 2 years ago

LukaszGrela commented 2 years ago

I'm working with React 18 and when I tried to install this module I was reported:

npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.0.0 || ^16.0.0" from react-aria-modal@4.0.1

Would you support React 17/18?

votemike commented 2 years ago

Maybe create a PR?

themagickoala commented 2 years ago

PR here: https://github.com/davidtheclark/react-aria-modal/pull/127

sfiggins commented 1 year ago

I am +1 for this PR. My current workaround is to set legacy peer deps to true in my project's .npmrc.

npm config set legacy-peer-deps=true --location=project

But a simple 4.0.2 release with this one change would be appreciated.

pkletsko commented 1 year ago

Can you please prioritise this PR. Really need it.

MBondarchuk-dev commented 1 year ago

Is there any progress with this issue? My team needs it as well.