search

davidtheclark / react-aria-modal

A fully accessible React modal built according WAI-ARIA Authoring Practices
http://davidtheclark.github.io/react-aria-modal/demo/
MIT License
1.03k stars 96 forks source link

chore: update peer dependencies for React 17 #127

Closed themagickoala closed 1 year ago

themagickoala commented 2 years ago

I have updated the peer dependencies such that React 17 is supported. I have left 18 as unsupported because I believe there's still a dependency that uses unsafe methods. I'm happy to adjust this if needed though.

Notably the peer dependency conflict has been exacerbated by the recent release of Node 16.15.1, which causes an npm install failure due to this issue. I have had to fix my Dockerfile base image to 16.15.0 until this can be resolved.

pdavenport commented 1 year ago

is this clear to get merged? would love to have this updated so my org can continue using it

v-mukhin commented 1 year ago

@davidtheclark @tristen any updates related to this issue?

themagickoala commented 1 year ago

Thanks @tristen for merging this. Do we know if there's anything blocking React 18 support? Has this Library been tested with React 18?

tristen commented 1 year ago

@themagickoala this project is very much in maintenance mode. I'd be happy to review a PR that supports React 18 though 👍