search

davidtheclark / react-aria-modal

A fully accessible React modal built according WAI-ARIA Authoring Practices
http://davidtheclark.github.io/react-aria-modal/demo/
MIT License
1.03k stars 96 forks source link

Can't navigate to browser chrome #40

Closed jlous closed 5 years ago

jlous commented 6 years ago

To qualify as fully accessible, it should (at least optionally) be possible to tab out into the browser chrome, as with normal pages.

This guy has some good input on accessibility and modals (although without considering react): https://www.smashingmagazine.com/2014/09/making-modal-windows-better-for-everyone/

davidtheclark commented 6 years ago

Thanks! Found that point and example code in the "Going full screen" section. Open to a PR fixing this, probably in focus-trap.

davidtheclark commented 6 years ago

@jlous — Curious: Have you seen any examples of accessible modals that do this (or recommendations besides that article)? Every example I come across contains focus completely within the modal.

jlous commented 6 years ago

No, I have not. But I was drawn to this implementation because it generally takes usability seriously.

On Aug 26, 2017 19:16, "David Clark" notifications@github.com wrote:

@jlous https://github.com/jlous — Curious: Have you seen any examples of accessible modals that do this (or recommendations besides that article)? Every example I come across contains focus completely within the modal.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/davidtheclark/react-aria-modal/issues/40#issuecomment-325148413, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOnUAwo9x-3a0k4Y1TdY-I1DMlQ8gtLks5scFLdgaJpZM4OvYxB .

jlous commented 6 years ago

This is by no means make-or-break to my use case, and I have not yet addressed it in the homebrew solution I ended up with. Just put it out there in case the most accessibility-conscious modal could conquer this point too. But i see how it would require maybe too much change. Even the solution in the article I mentioned only works one way out of the dialog.

On Aug 26, 2017 19:16, "David Clark" notifications@github.com wrote:

@jlous https://github.com/jlous — Curious: Have you seen any examples of accessible modals that do this (or recommendations besides that article)? Every example I come across contains focus completely within the modal.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/davidtheclark/react-aria-modal/issues/40#issuecomment-325148413, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOnUAwo9x-3a0k4Y1TdY-I1DMlQ8gtLks5scFLdgaJpZM4OvYxB .

davidtheclark commented 5 years ago

I'm unable to find sufficient confirmation that this is desirable and expected behavior for a modal, so I'm going to close. If someone is able to show that more than one expert believes this is the right thing to do, please open an issue in focus-trap, the library that tries to manage focus.