search

davidtheclark / react-aria-modal

A fully accessible React modal built according WAI-ARIA Authoring Practices
http://davidtheclark.github.io/react-aria-modal/demo/
MIT License
1.03k stars 96 forks source link

Scrolling within modal #43

Closed AlecRust closed 6 years ago

AlecRust commented 6 years ago

This module prevents scroll of the page when a modal is opened with no-scroll, which is what I'm after.

However this also seems to disable scrolling of content within the modal. For example I have a 3rd party <iframe> inside which I can't find a way to make scrollable.

Perhaps react-aria-modal could only disable the scroll of the main page, but nothing else?

davidtheclark commented 6 years ago

@AlecRust: no-scroll disables scrolling on the document, not on the modal or the fixed-position modal's backdrop. So you can have internal scrolling within the modal or backdrop.

I'm not sure I'm understanding the issue correctly, though — sounds like you're running into problems with an iframe, specifically, not the modal?

AlecRust commented 6 years ago

You're absolutely right, my apologies. I was having an iframe scroll issue, nothing to do with react-aria-modal :)