search

davidtheclark / react-aria-modal

A fully accessible React modal built according WAI-ARIA Authoring Practices
http://davidtheclark.github.io/react-aria-modal/demo/
MIT License
1.03k stars 96 forks source link

noScroll Prop, problem with recaptcha #46

Closed codingcircus closed 6 years ago

codingcircus commented 6 years ago

I just saw, that there was already an issue for adding a prop to turn off the noscroll functionality (https://github.com/davidtheclark/react-aria-modal/issues/39), where you said you won't do this for now, however this morning I ran into a problem with the noScroll part of the modal.

I have a modal with a form inside that uses googles invisble recaptcha. Unfortunately the position fixed and negative top you apply via no-scroll led to the captcha part (selecting pictures …) being somewhere off the screen.

Currently I set the noScroll to off manually, but it would be nicer, if there was a way to not even turn it on in the first place. If you want I can also send a PR for a possible solution.

davidtheclark commented 6 years ago

I guess if adding another prop won't be a big deal if there are these necessary use cases. Please submit a PR and I'll take a look. Thanks!

davidtheclark commented 6 years ago

Closed by #49.