search

davidtheclark / react-aria-modal

A fully accessible React modal built according WAI-ARIA Authoring Practices
http://davidtheclark.github.io/react-aria-modal/demo/
MIT License
1.04k stars 96 forks source link

Support React 16 #48

Closed davidtheclark closed 7 years ago

davidtheclark commented 7 years ago

Closes #47.

oyeanuj commented 7 years ago

@davidtheclark I'm curious about your thoughts wrt to the new Portal API in React 16? Is that something you are thinking react-aria-modal will/needs to make use of?

davidtheclark commented 7 years ago

@oyeanuj It's already in play! This package uses react-displace behind-the-scenes to accomplish what Portals are all about. The React 16 release of react-displace included some new logic to use Portals when they're available (e.g. https://github.com/davidtheclark/react-displace/blob/85a7833c28af37659ec4222218c80e15b157c8cd/src/displace.js#L79-L86).

So if you are using React 16 and the latest version of this package, you should be using Portals, I believe.

I'm working on upgrading my codebases at work to use React 16 but I'm not there yet, so haven't really battle-tested the new setup yet ... Let me know how it works for you!