davidtheclark / react-aria-modal

A fully accessible React modal built according WAI-ARIA Authoring Practices
http://davidtheclark.github.io/react-aria-modal/demo/
MIT License
1.03k stars 96 forks source link

Upgrade react-focus-trap and react-displace for React 16 peer dependency #50

Closed AlmeroSteyn closed 6 years ago

AlmeroSteyn commented 6 years ago

The current version of react-aria-modal gives peer dependency warnings when using React 16. This is due to the versions of react-focus-trap and react-displace being used not yet supporting React 16.

I upgraded to the versions that do support React 16 to make the warnings go away.

I also added the yarn.lock file changes.

davidtheclark commented 6 years ago

I guess I missed that step amid all the upgrade efforts. Thanks @AlmeroSteyn for diagnosing and fixing. I'll merge and release.

AlmeroSteyn commented 6 years ago

Only a pleasure! Thanks for merging.