search

davidtheclark / react-aria-modal

A fully accessible React modal built according WAI-ARIA Authoring Practices
http://davidtheclark.github.io/react-aria-modal/demo/
MIT License
1.03k stars 96 forks source link

Can't set returnFocusOnDeactivate on FocusTrap #55

Closed cnelson9 closed 6 years ago

cnelson9 commented 6 years ago

I have a scenario where I need to set returnFocusOnDeactivate to false on the FocusTrap, but there is no way for me to set it with the AriaModal props.

I would make a PR, but I don't have permission to publish a branch.

cnelson9 commented 6 years ago

Actually, it would be nice if I could pass in all of focusTrapOptions

davidtheclark commented 6 years ago

@cnelson9 sounds good. Open to a PR implementing focusTrapOptions.

I would make a PR, but I don't have permission to publish a branch.

You should be able to create a PR by forking the repo and working from the fork. There are some guides you can find if you search for how to contribute pull requests on GitHub (like this one).

davidtheclark commented 6 years ago

Closed by #56.