Switch from using react-displace to using react-portals.

davidtheclark / react-aria-modal

A fully accessible React modal built according WAI-ARIA Authoring Practices

http://davidtheclark.github.io/react-aria-modal/demo/

MIT License

1.03k stars 96 forks source link

Switch from using react-displace to using react-portals. #67

Closed Ross-Esmond closed 6 years ago

Ross-Esmond commented 6 years ago

Portals makes react-displace redundant. Discussion from react-displace repo. Removing one more dependency would be nice, although it would change react compatibility from 15 to 16 and might require a breaking API change. It might make since to "shelve" this issue but leave it in the backlog for the next major version, if and when that comes.

I can help out with this one if you'd like.

davidtheclark commented 6 years ago

Thanks @Ross-Esmond. react-displace uses Portals when they're available and older methods when they're not. I'm not planning to remove compatibility for React 15 just yet, so still don't want to shake the react-displace dependency.