davidtheclark / react-aria-modal

A fully accessible React modal built according WAI-ARIA Authoring Practices
http://davidtheclark.github.io/react-aria-modal/demo/
MIT License
1.03k stars 96 forks source link

Not able to tab into iframe #68

Closed mtrueblood closed 5 years ago

mtrueblood commented 6 years ago

When we put an iframe into the modal-body, we're unable to tab into the iframe.

I even went to the demo page and updated the modal-body section of demo number 5 with a random youtube iframe embed code. I'm unable to tab and click to watch the video and the focus then gets stuck on the 'deactivate modal' button. Here is a screenshot: image

We're having the same issue, however our close button comes before the iframe. When we tab once, we get our close button, when we tab again expecting to now be on the iframe, we're actually stuck on the close button and cannot get into the iframe.

davidtheclark commented 6 years ago

Yeah, this is a known issue with the lower-level tabbable library: https://github.com/davidtheclark/tabbable/issues/23. Solutions welcome!

davidtheclark commented 5 years ago

Closing here, as the root problem is in tabbable and focus-trap.